Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Vietnamese localization ('vi') #13

Closed
wants to merge 4 commits into from
Closed

Added support for Vietnamese localization ('vi') #13

wants to merge 4 commits into from

Conversation

trinhvuduc
Copy link

No description provided.

simonpham
simonpham approved these changes Aug 15, 2022
View reviewed changes
Copy link

@simonpham simonpham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zulfahmi93 please consider merging this PR 🙌

@vhphuc
Copy link

vhphuc commented Aug 16, 2022 •
edited
Loading

#2 (comment)
Maybe also consider to make a seperate PRs for translation and 'Fit months in view'.
In case commit 'Fit months in view' need some alteration then translation does not get blocked.
You can review this PR #12 for 'Fit months in view'

@zulfahmi93
Copy link
Owner

Merged with this commit.

@zulfahmi93 zulfahmi93 closed this Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhphuc vhphuc vhphuc left review comments

@simonpham simonpham simonpham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trinhvuduc @vhphuc @zulfahmi93 @simonpham