Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to select target by general css selector. #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aratak
Copy link

@aratak aratak commented Feb 22, 2013

  <li data-selector="header > #menu #profile">Tip content...</li>

@juuliaans
Copy link
Contributor

This is cool! i like it.

@colllin
Copy link

colllin commented Mar 23, 2013

I was thinking the same thing. Do you think data-target would be a clearer name for it?

I would be in favor of removing data-id and data-class support. Not that you could do that, for backwards compatibility, but they could be removed from the documentation in favor of data-target.

@mburtscher
Copy link

I'd really like to see that feature. Just opened exactly the same pull request o_0

@spilliton
Copy link

I could use this as well 👍

@aentan
Copy link

aentan commented Jun 17, 2013

Is this going to be pulled?

@aratak
Copy link
Author

aratak commented Jun 17, 2013

@aentan, +1.
Seems, @zurb forget about current PR.

@parrish
Copy link

parrish commented Jul 22, 2013

I was just about to fork and send a PR for this. Is there a reason this hasn't been merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants