GTIN extraction, Python 3.12 support #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
+ Coverage 95.45% 96.69% +1.24%
==========================================
Files 6 7 +1
Lines 220 303 +83
==========================================
+ Hits 210 293 +83
Misses 10 10 ☔ View full report in Codecov by Sentry. |
kmike
reviewed
Dec 25, 2023
kmike
reviewed
Dec 25, 2023
kmike
reviewed
Dec 25, 2023
docs/intro.rst
Outdated
| @@ -4,7 +4,8 @@ Intro | |||
|
|
|||
| ``zyte-parsers`` provides functions that extract specific data from HTML | |||
| elements. The input element can be an instance of either | |||
| :class:`parsel.selector.Selector` or :class:`lxml.html.HtmlElement`. | |||
| :class:`parsel.selector.Selector` or :class:`lxml.html.HtmlElement`. Some | |||
| functions also support passing a string as input. | |||
There was a problem hiding this comment.
I think we should clarify what thi string is: should it be a string with HTML to extractd data from, or should it be text extracted from a HTML element?
There was a problem hiding this comment.
extracted from a HTML element
Or elsewhere (e.g. JSON, regexp).
kmike
approved these changes
Dec 25, 2023
Gallaecio
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.