Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LocationParam #55

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Add LocationParam #55

merged 4 commits into from
Jul 22, 2024

Conversation

VMRuiz
Copy link
Contributor

@VMRuiz VMRuiz commented Jul 19, 2024

No description provided.

@VMRuiz VMRuiz requested review from wRAR and Gallaecio July 19, 2024 07:57
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.97%. Comparing base (ecfccdf) to head (2e3531f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   98.93%   98.97%   +0.04%     
==========================================
  Files          13       13              
  Lines         562      584      +22     
==========================================
+ Hits          556      578      +22     
  Misses          6        6              
Files Coverage Δ
zyte_spider_templates/params.py 100.00% <100.00%> (ø)

@VMRuiz
Copy link
Contributor Author

VMRuiz commented Jul 19, 2024

There seems to be some issues with mypy typing. Could you please recommend what's the best way to fix it?

@VMRuiz
Copy link
Contributor Author

VMRuiz commented Jul 19, 2024

I added some exceptions in tests code for mypy errors because I couldn't make them work in the class definition itself.
Also, there is another error about a licence in twine pipeline

@wRAR
Copy link
Member

wRAR commented Jul 19, 2024

The twine problem is global and should be fixed by bumping the deps in twinecheck

Copy link
Contributor

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess docs will make more sense once we actually implement a location parameter for spiders.

@VMRuiz VMRuiz merged commit 61d85b2 into main Jul 22, 2024
13 checks passed
@wRAR wRAR deleted the feature/location-params branch October 18, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants