Basic job postings website. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gallaecio
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Looks good to me already. I imagine those to-dos could/should be addressed later on.
My only concern is layouts, i.e. whether automatic extraction will be able to pick job data from them as they are. Not sure if that’s something that needs addressing at this point, though.
|
Well, we should check that before merging and fix if needed :) I also plan to add more fields first. |
|
OTOH making sure extraction works wasn't planned for the first stage, so I should only add more fields, more generated data and pagination. |
kmike
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.