IGNITE-21688 Remove modernizer from build checks (apache#3421)

.run/All checks [PMD, modernizer, spotbugs, checkstyle].run.xml → .run/All checks [PMD, spotbugs, checkstyle].run.xml

@@ -1,5 +1,5 @@
 <component name="ProjectRunConfigurationManager">
-  <configuration default="false" name="All checks [PMD, modernizer, spotbugs, checkstyle]" type="GradleRunConfiguration" factoryName="Gradle" folderName="Checks">
+  <configuration default="false" name="All checks [PMD, spotbugs, checkstyle]" type="GradleRunConfiguration" factoryName="Gradle" folderName="Checks">
     <ExternalSystemSettings>
       <option name="executionName" />
       <option name="externalProjectPath" value="$PROJECT_DIR$" />
@@ -12,7 +12,6 @@
         <list>
           <option value="pmdMain" />
           <option value="pmdTest" />
-          <option value="modernizer" />
           <option value="spotbugsMain" />
           <option value="checkstyleMain" />
           <option value="checkstyleIntegrationTest" />
@@ -25,6 +24,7 @@
     <ExternalSystemDebugServerProcess>true</ExternalSystemDebugServerProcess>
     <ExternalSystemReattachDebugProcess>true</ExternalSystemReattachDebugProcess>
     <DebugAllEnabled>false</DebugAllEnabled>
+    <RunAsTest>false</RunAsTest>
     <method v="2" />
   </configuration>
-</component>
+</component>

DEVNOTES.md

@@ -75,22 +75,6 @@ Run code style checks only:
 Code style check results are generated at:
 * `<mudule-dir>/build/reports/checkstyle/`
 
-### Legacy API
-The project is checked for legacy APIs with [Modernizer Gradle Plugin](https://plugins.gradle.org/plugin/com.github.andygoossens.gradle-modernizer-plugin).
-* [Modernizer rules](check-rules/modernizer-rules.xml)
-
-Plugin is enabled by default and is bound to `build` task.
-
-Build project without legacy API check:
-```shell
-./gradlew clean build -x modernizer
-```
-
-Run legacy API checks only:
-```shell
-./gradlew modernizer
-```
-
 ### Spotbugs
 The project is checked for bugs with [Spotbugs Gradle Plugin](https://github.com/spotbugs/spotbugs-gradle-plugin).
 * [Spotbugs exclusion rules](check-rules/spotbugs-excludes.xml)

build.gradle

@@ -21,7 +21,6 @@ plugins {
     id('idea')
     alias(libs.plugins.ideaext)
     alias(libs.plugins.javacc) apply false
-    alias(libs.plugins.modernizer) apply false
     alias(libs.plugins.aggregateJavadoc)
     alias(libs.plugins.spotbugs) apply false
 }

buildscripts/java-core.gradle

@@ -20,7 +20,6 @@ apply plugin: 'jacoco'
 apply plugin: 'checkstyle'
 apply plugin: 'pmd'
 apply plugin: 'java-library'
-apply plugin: libs.plugins.modernizer.get().pluginId
 apply plugin: libs.plugins.spotbugs.get().pluginId
 
 java {
@@ -85,15 +84,6 @@ tasks.withType(Checkstyle) {
     }
 }
 
-modernizer {
-    failOnViolations = true
-    includeTestClasses = false
-    violationsFile = "${rootDir}/check-rules/modernizer-rules.xml"
-    ignorePackages = ["org.apache.ignite.internal.sql.engine",
-                      "org.apache.ignite.internal.generated",
-                      "org.apache.ignite.rest.client"]
-}
-
 javadoc {
     source = sourceSets.main.allJava
     classpath = configurations.compileClasspath

gradle/libs.versions.toml

@@ -94,7 +94,6 @@ openapiGenerator = "org.openapi.generator:7.3.0"
 javacc = "com.intershop.gradle.javacc:4.1.3"
 shadow = "com.github.johnrengelman.shadow:7.1.2"
 cmake = "net.freudasoft.gradle-cmake-plugin:0.0.4"
-modernizer = "com.github.andygoossens.modernizer:1.9.2"
 nebula = "com.netflix.nebula.ospackage:11.8.1"
 docker = "com.palantir.docker:0.35.0"
 checksum = "org.gradle.crypto.checksum:1.4.0"