Build upgrade and Release 0.20.0 #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedefernandez
previously approved these changes
Dec 27, 2018
| @@ -36,7 +35,7 @@ trait GHIssuesSpec[T] extends BaseIntegrationSpec[T] { | |||
| }) | |||
| } | |||
|
|
|||
| "Issues >> Get" should "return an issue which is a PR" in { | |||
| "Issues >> Get" should "return an issue which is a PR" ignore { | |||
There was a problem hiding this comment.
Should we create an issue for this?
There was a problem hiding this comment.
I think it's related to #233
juanpedromoreno
force-pushed
the
jp-build-upgrade-release-0.20.0
branch
from
cf0b03c to
fdd2339
Compare
juanpedromoreno
dismissed stale reviews from fedefernandez and BenFradet
Added new fixes/changes
|
@BenFradet @fedefernandez I'm requesting again your review since I've added more changes in order to complete the Scalajs upgrade. |
fedefernandez
approved these changes
Dec 27, 2018
Merged
|
Can you upload the artifacts to maven, please? |
|
They should be there, that PR deployed artifacts automatically ;) |
|
Now I see them. Previously they were missing. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the build to the latest version of
cats,cats-effect,circe, etc. Additionally, it ignores a random test failure.Releases 0.20.0.