Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update actions/upload-artifact and actions/download-artifact from 3 to 4 #1062

Merged
merged 5 commits into from
Jan 25, 2024

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Jan 24, 2024

Summary by CodeRabbit

  • Chores
    • Updated versions of GitHub Actions for improved artifact handling and coverage reporting.

@Czaki Czaki added this to the 0.15.3 milestone Jan 24, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: This pull request updates the GitHub Actions artifacts actions from version 3 to version 4. It includes changes to the workflows to use the newer version of both actions/upload-artifact and actions/download-artifact. Additionally, it introduces more descriptive naming for coverage report artifacts and enables the merging of multiple coverage reports into a single artifact.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.

General suggestions:

  • Ensure that the new features and changes in version 4 of the GitHub Actions artifacts are fully compatible with the existing workflow.
  • Verify that the new naming convention for coverage reports is consistently applied across all workflows.
  • Confirm that the merge of multiple coverage reports into a single artifact does not disrupt any subsequent steps that process these reports.
  • Review the release notes of the updated actions to ensure there are no breaking changes affecting the workflow.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link
Contributor

coderabbitai bot commented Jan 24, 2024

Walkthrough

The changes in the workflow files involve updating the versions of the GitHub Actions used for uploading and downloading artifacts. Specifically, the actions/upload-artifact, actions/download-artifact, and codecov/codecov-action have been updated from version 3 to version 4. Additionally, the download-artifact action was updated from v3 to v4, and the upload-artifact action was similarly updated from v3 to v4. The name parameter in the Upload coverage data step was modified to include several input variables. The actions/download-artifact step now includes the merge-multiple: true parameter. These updates likely bring improvements or new features to the workflow, especially in artifact handling and coverage reporting.

Changes

File Path Change Summary
.github/workflows/base_test_workflow.yml,
.github/workflows/tests.yml
Updated actions/upload-artifact, actions/download-artifact to v4; codecov/codecov-action to v4; added merge-multiple: true.

🐇✨
In workflows' land, amidst the code and clatter,
A bunny hopped in, to make things better.
With a twitch of its nose, and a swift little dance,
Artifacts align, in the GitHub expanse. 🎉
🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between a004be5 and 3587a85.
Files selected for processing (4)
  • .github/workflows/base_test_workflow.yml (2 hunks)
  • .github/workflows/test_napari_repo.yml (2 hunks)
  • .github/workflows/test_prereleases.yml (3 hunks)
  • .github/workflows/tests.yml (4 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/test_napari_repo.yml
Additional comments: 10
.github/workflows/base_test_workflow.yml (2)
  • 74-74: The actions/download-artifact action has been updated to version 4.
  • 103-106: The actions/upload-artifact action has been updated to version 4, and the name parameter has been modified to include several input variables, enhancing the clarity of coverage data.
.github/workflows/test_prereleases.yml (4)
  • 26-26: The actions/upload-artifact action has been updated to version 4.
  • 62-62: The actions/download-artifact action has been updated to version 4.
  • 118-118: The actions/upload-artifact action has been updated to version 4 for uploading requirements.
  • 125-125: The actions/upload-artifact action has been updated to version 4 for uploading the bundle.
.github/workflows/tests.yml (4)
  • 28-28: The actions/upload-artifact action has been updated to version 4.
  • 136-140: The actions/download-artifact action has been updated to version 4 with the addition of merge-multiple: true and pattern: cov-reports-*. This change likely improves the handling of multiple coverage reports.
  • 156-156: The codecov/codecov-action has been updated to version 4.
  • 180-180: The actions/download-artifact action has been updated to version 4 in the test_conda job.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 3587a85 and 38f3fae.
Files selected for processing (2)
  • .github/workflows/base_test_workflow.yml (2 hunks)
  • .github/workflows/tests.yml (6 hunks)
Files skipped from review as they are similar to previous changes (2)
  • .github/workflows/base_test_workflow.yml
  • .github/workflows/tests.yml

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 38f3fae and 8154bb1.
Files selected for processing (1)
  • .github/workflows/base_test_workflow.yml (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/base_test_workflow.yml

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 8154bb1 and df2fcb0.
Files selected for processing (1)
  • .github/workflows/tests.yml (5 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/tests.yml

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Czaki Czaki merged commit de43a4f into develop Jan 25, 2024
43 checks passed
@Czaki Czaki deleted the artifact_actions_update branch January 25, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant