-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Update actions/upload-artifact
and actions/download-artifact
from 3 to 4
#1062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Type: Enhancement
PR Summary: This pull request updates the GitHub Actions artifacts actions from version 3 to version 4. It includes changes to the workflows to use the newer version of both actions/upload-artifact
and actions/download-artifact
. Additionally, it introduces more descriptive naming for coverage report artifacts and enables the merging of multiple coverage reports into a single artifact.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Ensure that the new features and changes in version 4 of the GitHub Actions artifacts are fully compatible with the existing workflow.
- Verify that the new naming convention for coverage reports is consistently applied across all workflows.
- Confirm that the merge of multiple coverage reports into a single artifact does not disrupt any subsequent steps that process these reports.
- Review the release notes of the updated actions to ensure there are no breaking changes affecting the workflow.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
WalkthroughThe changes in the workflow files involve updating the versions of the GitHub Actions used for uploading and downloading artifacts. Specifically, the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (4)
- .github/workflows/base_test_workflow.yml (2 hunks)
- .github/workflows/test_napari_repo.yml (2 hunks)
- .github/workflows/test_prereleases.yml (3 hunks)
- .github/workflows/tests.yml (4 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/test_napari_repo.yml
Additional comments: 10
.github/workflows/base_test_workflow.yml (2)
- 74-74: The
actions/download-artifact
action has been updated to version 4.- 103-106: The
actions/upload-artifact
action has been updated to version 4, and thename
parameter has been modified to include several input variables, enhancing the clarity of coverage data..github/workflows/test_prereleases.yml (4)
- 26-26: The
actions/upload-artifact
action has been updated to version 4.- 62-62: The
actions/download-artifact
action has been updated to version 4.- 118-118: The
actions/upload-artifact
action has been updated to version 4 for uploading requirements.- 125-125: The
actions/upload-artifact
action has been updated to version 4 for uploading the bundle..github/workflows/tests.yml (4)
- 28-28: The
actions/upload-artifact
action has been updated to version 4.- 136-140: The
actions/download-artifact
action has been updated to version 4 with the addition ofmerge-multiple: true
andpattern: cov-reports-*
. This change likely improves the handling of multiple coverage reports.- 156-156: The
codecov/codecov-action
has been updated to version 4.- 180-180: The
actions/download-artifact
action has been updated to version 4 in thetest_conda
job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- .github/workflows/base_test_workflow.yml (2 hunks)
- .github/workflows/tests.yml (6 hunks)
Files skipped from review as they are similar to previous changes (2)
- .github/workflows/base_test_workflow.yml
- .github/workflows/tests.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/base_test_workflow.yml (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/base_test_workflow.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/tests.yml (5 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/tests.yml
|
Summary by CodeRabbit