Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update actions/upload-artifact and actions/download-artifact from 3 to 4 #1062

Merged
merged 5 commits into from
Jan 25, 2024
Merged

ci: Update actions/upload-artifact and actions/download-artifact from 3 to 4 #1062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3587a85
update `actions/upload-artifact` and `actions/download-artifact` fro…
Czaki Jan 24, 2024
736b774
bump missed one
Czaki Jan 24, 2024
38f3fae
fix configuration
Czaki Jan 25, 2024
8154bb1
add coverage information to name
Czaki Jan 25, 2024
df2fcb0
fix coverage action
Czaki Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/base_test_workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:

- name: Download test data
if: ${{ inputs.test_data }}
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: test_data
path: test_data
Expand All @@ -92,17 +92,17 @@ jobs:
BACKEND: ${{ inputs.qt_backend }}
PIP_CONSTRAINT: requirements/constraints_py${{ inputs.python_version }}.txt

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: upload pytest timing reports as json
name: timing-report-${{ inputs.os }}-py-${{ inputs.python_version }}-${{ inputs.napari }}-${{ inputs.qt_backend }}-${{ inputs.coverage }}
path: |
./report-*.json
retention-days: 7

- name: Upload coverage data
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ inputs.coverage }}
with:
name: coverage reports
name: cov-reports-${{ inputs.os }}-py-${{ inputs.python_version }}-${{ inputs.napari }}-${{ inputs.qt_backend }}
path: |
./.coverage.*
4 changes: 2 additions & 2 deletions .github/workflows/test_napari_repo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- shell: bash
run: bash build_utils/download_data.sh
- name: Upload test data
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: test_data
path: test_data
Expand Down Expand Up @@ -54,7 +54,7 @@ jobs:
pip install setuptools tox tox-gh-actions

- name: Download test data
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: test_data
path: test_data
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/test_prereleases.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- shell: bash
run: bash build_utils/download_data.sh
- name: Upload test data
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: test_data
path: test_data
Expand Down Expand Up @@ -59,7 +59,7 @@ jobs:
- uses: tlambert03/setup-qt-libs@v1

- name: Download test data
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: test_data
path: test_data
Expand Down Expand Up @@ -115,14 +115,14 @@ jobs:
pip-sync
pip install .
- name: upload requirements
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: requirements
path: requirements.txt
- name: Run PyInstaller
run: python build_utils/create_and_pack_executable.py
- name: Upload bundle
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: bundle
path: dist2/
Expand Down
15 changes: 8 additions & 7 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- shell: bash
run: bash build_utils/download_data.sh
- name: Upload test data
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: test_data
path: test_data
Expand Down Expand Up @@ -102,8 +102,8 @@ jobs:
uses: ./.github/workflows/base_test_workflow.yml
with:
test_data: True
python_version: "3.8"
tox_args: "-e py38-PyQt5-coverage"
python_version: "3.10"
tox_args: "-e py310-PyQt5-coverage"
coverage: true

test_minimal:
Expand Down Expand Up @@ -133,10 +133,11 @@ jobs:
pip install codecov

- name: Download coverage data
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: coverage reports
pattern: cov-reports-*
path: coverage
merge-multiple: true
- name: combine coverage data
run: |
python -Im coverage combine coverage
Expand Down Expand Up @@ -176,7 +177,7 @@ jobs:
- uses: tlambert03/setup-qt-libs@v1

- name: Download test data
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: test_data
path: test_data
Expand All @@ -201,7 +202,7 @@ jobs:
run: bash build_utils/create_environment_yml.sh

- name: Upload environment file
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: environment
path: environment.yml
Expand Down
Loading