223-model-required

[charles-turner-1]

Changes

• I fixed up a couple of tangentially related bits in the translators - looks like some WIP got accidentally merged in the @tuplify_series decorator & moved that to a separate file.
• Added more thorough error handling, checking for specific data issues & pointing to [BUG] Make model required for metadata.yaml files #223 is it appears to be related.
• Tests for error handling.
  • The tests use mock raises - I'd really rather avoid this if possible & pass data broken in the specific expected ways, but it was sinking too much time so I'll raise it as a new issue & come back to check.

[codecov]

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.98%. Comparing base (6d9bf87) to head (f9130f3).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
src/access_nri_intake/catalog/manager.py	85.71%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
+ Coverage   97.75%   97.98%   +0.22%     
==========================================
  Files          10       11       +1     
  Lines         803      843      +40     
==========================================
+ Hits          785      826      +41     
+ Misses         18       17       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[charles-turner-1]

Will require intake-dataframe-catalog too in order to work properly.

[rbeucher]

Should we try to fix the coverage?

[charles-turner-1]

Yeah, it's just a straightforward catch all that needs an additional test - should take 5 minutes, I'll do it first thing Monday.