Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

223 Model Required #71

Merged
merged 1 commit into from
Nov 15, 2024
Merged

223 Model Required #71

merged 1 commit into from
Nov 15, 2024

Conversation

charles-turner-1
Copy link
Collaborator

This is a sister PR to 223-model required in access-nri-intake-catalog.

  • Lets the user know if they have missing iterable columns or unexpected iterable columns, and describes the issue in more detail.
  • All additional logic is inside the error handling so should be no potential performance hits.
  • Tests for this extra logic

@charles-turner-1
g This is a combination of 2 commits.
2a9a5d5 
- Updated DfFileCatalog.add and related tests to describe errors relating to columns with iterables in a more satisfactory manner
@charles-turner-1 charles-turner-1 mentioned this pull request Nov 15, 2024
Open
@charles-turner-1 charles-turner-1 changed the title 223 Model Requierd 223 Model Required Nov 15, 2024
@rbeucher rbeucher merged commit b0e5070 into main Nov 15, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbeucher rbeucher rbeucher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charles-turner-1 @rbeucher