-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Execution Policy setting to Powershell based shell plugins #1505
Add Execution Policy setting to Powershell based shell plugins #1505
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
1629623
to
cab9ec3
Compare
I rebased to get the CI fixed, but the PR needs DCO fixed (commit signoff) |
I believe there is only like 5 executionpolicy types that are valid, can we
just list only those as valid and check for them / error if not?
|
Yes that would be pretty easy to do and prevent injections
|
We could add strict values, but why not just use a regex and save us the trouble of having to follow windows/powershell releases/changes? |
I'm fine with either. |
@maxnbk you forgot to add |
Hi @herronelou , do you think you could follow the instructions at https://github.com/AcademySoftwareFoundation/rez/pull/1505/checks?check_run_id=16687974501 please? I'd like to merge this but we need commits to be signed off. Thanks! |
ba8061b
to
de017f6
Compare
Signed-off-by: Erwan Leroy <[email protected]>
de017f6
to
e9979b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Hopefully that will be enough for when we enable power shell by default in 3.0.
@JeanChristopheMorinPerso can you confirm if I fixed it fine? |
Yep, it looks fine. The DCO bot says that everything is properly signed off. |
aff89bd
into
AcademySoftwareFoundation:main
Thanks @herronelou, this will be released in 3.0. |
…mySoftwareFoundation#1505) Signed-off-by: Erwan Leroy <[email protected]> Signed-off-by: Jose Enriquez <[email protected]>
Closes #1504
This is a simple implementation of what I was requesting in #1504
I considered a different approach which would have been a bit more generic such as
shell_args
, which could have included the-NoLogo
which is currently being inserted all the time. However, after reviewing the other shell plugins, I couldn't see the case for shell args for all of them, so I kept it localized to only doing exactly what I needed.