fix: use selectingChildrenSelectsParent instead of selectingChildrenSelectsParents #1106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using
ember-table
, I noticed I was getting a type error when passingselectingChildrenSelectsParent
to thet.body
component (see Selection Mode docs and usage in code)I had a quick scan through the code and noticed in the types it was wrongfully defined as
selectingChildrenSelectsParents
(with a trailing "s").This PR fixes that.