Skip to content

Commit

Permalink
add note about keratinocytes
Browse files Browse the repository at this point in the history
  • Loading branch information
allyhawkins committed Dec 18, 2024
1 parent e3ad414 commit 3676e8d
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ print_df |>
```

The PanglaoDB cell types seem to be more specific than the ones present in Blueprint Encode, similar to the observation with neurons.
We should keep epithelial cell.
We should keep epithelial cell in the cases where the Blueprint Encode annotation is `Epithelial cells` but not when it is `Keratinocytes`.

### Removing anything with more than 1 LCA

Expand Down Expand Up @@ -605,7 +605,8 @@ I would use the following criteria to come up with my whitelist:

- Pairs should not have more than 1 LCA, with the exception of the matches that have the label hematopoietic precursor cell.
- The LCA should have equal to or less than 170 total descendants.
- We whould include the term for `neuron` and `epithelial cell` even though they do not pass the threshold for number of descendants.
- We should include the term for `neuron` and `epithelial cell` even though they do not pass the threshold for number of descendants.
However, `epithelial cell` should only be included if the Blueprint Encode name is `Epithelial cells` and _not_ `Keratinocytes`.
- Terms that are too broad should be removed.
This includes: `lining cell`, `blood cell`, `progenitor cell`, `bone cell`, and `supporting cell`

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

<meta name="author" content="Ally Hawkins" />

<meta name="date" content="2024-12-17" />
<meta name="date" content="2024-12-18" />

<title>Summary of cell type ontologies in reference files</title>

Expand Down Expand Up @@ -441,7 +441,7 @@
<h1 class="title toc-ignore">Summary of cell type ontologies in
reference files</h1>
<h4 class="author">Ally Hawkins</h4>
<h4 class="date">2024-12-17</h4>
<h4 class="date">2024-12-18</h4>

</div>

Expand Down Expand Up @@ -512,7 +512,7 @@ <h2>Setup</h2>
panglao_annotation = &quot;human_readable_value&quot;
)</code></pre>
<pre><code>## Rows: 178 Columns: 3
## ── Column specification ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
## ── Column specification ──────────────────────────────────────────────────────────────────────────────────────────────────────
## Delimiter: &quot;\t&quot;
## chr (3): ontology_id, human_readable_value, panglao_cell_type
##
Expand Down Expand Up @@ -693,8 +693,8 @@ <h2>Latest common ancestor (LCA) between PanglaoDB and Blueprint
dplyr::mutate(lca = dplyr::if_else(blueprint_ontology == panglao_ontology, blueprint_ontology, lca)) |&gt;
# join in information for each of the lca terms including name, number of ancestors and descendants
dplyr::left_join(cl_df, by = c(&quot;lca&quot; = &quot;cl_ontology&quot;)) </code></pre>
<pre><code>## Warning: Expected 3 pieces. Missing pieces filled with `NA` in 7967 rows [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19,
## 20, ...].</code></pre>
<pre><code>## Warning: Expected 3 pieces. Missing pieces filled with `NA` in 7967 rows [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17,
## 18, 19, 20, ...].</code></pre>
<div id="distribution-of-ancestors-and-descendants" class="section level3">
<h3>Distribution of ancestors and descendants</h3>
<pre class="r"><code>ggplot(lca_df, aes(x = total_ancestors)) +
Expand Down Expand Up @@ -1733,7 +1733,7 @@ <h4>Myeloid leukocyte</h4>
then I would argue we shouldn’t keep myeloid leukocyte. Noting that
after discussion we have decided to keep this one since T and B cells
are much easier to differentiate based on gene expression alone than
cells that are party of the myeloid lineage.</p>
cells that are part of the myeloid lineage.</p>
</div>
<div id="progenitor-cell" class="section level4">
<h4>Progenitor cell</h4>
Expand Down Expand Up @@ -3347,7 +3347,9 @@ <h4>Epithelial cell</h4>
</div>
<p>The PanglaoDB cell types seem to be more specific than the ones
present in Blueprint Encode, similar to the observation with neurons. We
should keep epithelial cell.</p>
should keep epithelial cell in the cases where the Blueprint Encode
annotation is <code>Epithelial cells</code> but not when it is
<code>Keratinocytes</code>.</p>
</div>
</div>
<div id="removing-anything-with-more-than-1-lca" class="section level3">
Expand Down Expand Up @@ -3492,8 +3494,8 @@ <h3>Removing anything with more than 1 LCA</h3>

# which cell types are now missing from the list to keep
setdiff(celltypes_to_keep, updated_celltypes)</code></pre>
<pre><code>## [1] &quot;blood cell&quot; &quot;hematopoietic precursor cell&quot; &quot;lining cell&quot; &quot;perivascular cell&quot;
## [5] &quot;supporting cell&quot;</code></pre>
<pre><code>## [1] &quot;blood cell&quot; &quot;hematopoietic precursor cell&quot; &quot;lining cell&quot;
## [4] &quot;perivascular cell&quot; &quot;supporting cell&quot;</code></pre>
<p>It looks like I am losing a few terms I already said were not
specific and then a few other terms, like “hematopoietic precursor cell”
and “perivascular cell”. I’ll look at both of those to confirm we would
Expand Down Expand Up @@ -3909,9 +3911,12 @@ <h2>Conclusions</h2>
matches that have the label hematopoietic precursor cell.</li>
<li>The LCA should have equal to or less than 170 total
descendants.</li>
<li>We whould include the term for <code>neuron</code> and
<li>We should include the term for <code>neuron</code> and
<code>epithelial cell</code> even though they do not pass the threshold
for number of descendants.</li>
for number of descendants. However, <code>epithelial cell</code> should
only be included if the Blueprint Encode name is
<code>Epithelial cells</code> and <em>not</em>
<code>Keratinocytes</code>.</li>
<li>Terms that are too broad should be removed. This includes:
<code>lining cell</code>, <code>blood cell</code>,
<code>progenitor cell</code>, <code>bone cell</code>, and
Expand Down

0 comments on commit 3676e8d

Please sign in to comment.