-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add summary plots to guide notebook for Ewing annotation #1008
Add summary plots to guide notebook for Ewing annotation #1008
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine to me overall, and I don't have many comments! Just some small items...
- I don't love
auc_assignment
as a label for the density plot where it appears since I don't think it's very informative. Maybe we don't even need to include AUCell in the label and just go with something likein_geneset
? - The density plot in the section
Mean expression of custom gene sets
needs to be bigger to see all the strip labels - Some UMAPs have axis labels/ticks, and some don't. I'd remove these all around
- I might again turn off the row clustering in the heatmaps - in other words, don't have the heatmap cluster the clusters. But if this view is more informative for you, or if you don't think it matters, then I wouldn't bother
@@ -44,6 +44,10 @@ theme_set( | |||
|
|||
# set seed | |||
set.seed(2024) | |||
|
|||
# quiet messages | |||
options(readr.show_col_types = FALSE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh it is so tempting to put this in my ~/.Rprofile
😂
@sjspielman I made all the changes you suggested in #1008 (review) in f7829aa. This should be ready for another look! New copy of the report: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Purpose/implementation Section
Please link to the GitHub issue that this pull request addresses.
Continuing on #993
What is the goal of this pull request?
Here I'm filling in the section of the notebook that we will use to summarize the outputs from all the workflows, SingleR, clustering, AUCell and expression of custom marker genes. The goal is to be able to use these plots to help validate normal and tumor cell assignments. Then the next section will focus on adjusting any assignments based on these results and pulling out tumor cells for sub clustering and assignment of tumor cell states.
Briefly describe the general approach you took to achieve this goal.
plotting-functions.R
that includes functions for creating plots that are repeated (density, UMAPs, heatmaps). I envision being able to use these functions in later sections of the notebook.If known, do you anticipate filing additional pull requests to complete this analysis module?
Yes, next up will be the section that looks at sub clustering of tumor cells.
Provide directions for reviewers
Here's a rendered copy of the notebook for review:
celltype-exploration.html.zip
Author checklists
Analysis module and review
README.md
has been updated to reflect code changes in this pull request.Reproducibility checklist
Dockerfile
.environment.yml
file.renv.lock
file.