Add aws CLI to docker image for consensus cell typing #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaclyn-taroni
approved these changes
Dec 17, 2024
|
This is one option, but if we want to keep the docker image "pure" another option is to add a step to the test action to install the awscli there, as we do in OpenScPCA-analysis/.github/workflows/run_cell-type-wilms-tumor-14.yml Lines 44 to 48 in d89078c |
I can do this if we want to keep things consistent across modules. So maybe I'll close this and then add these lines in #936 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like https://github.com/AlexsLemonade/OpenScPCA-analysis/actions/runs/12381052804/job/34558746421 is failing because the AWS CLI is not in the docker image. I think I've seen this before when working on the Ewing module, but we use conda there and install it that way. Here, I just followed the install instructions for Linux to install it in the image. I think this should solve the issues with downloading test data in the GHA.