Keep original name from Panglao when creating consensus reference #976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on #969 and I noticed that we don't actually keep the original name used in the cell type assignment from Panglao/CellAssign when we create the reference table for consensus labels. We were only saving the cell ontology ID and the name in the cell ontology. This means we can't actually join that table with the
colData
for ScPCA samples since there won't be a column that matches.At first I thought we could just use the table that we made that maps each name from Panglao to the cell ontology ID, but there are cases where we have multiple ontology IDs that map to different Panglao assignments. So here I'm adding in a column to the consensus cell types and adding a few more rows to the reference that account for cases where the same ontology ID maps to different names in Panglao.