Samples page with processing information #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a HUGE fan of the direction this is going in! It will help members of our science team respond to experiment requests as well. |
4 tasks
|
This should be ready for review @davidsmejia. If you want to test it, you'll need to run a local version of the API since we haven't deployed the latest API changes. I added a bit more information to the page and collapsed all the jobs table in an accordion.
|
arielsvn
changed the title
…o arielsvn/internal-sample-page
…o arielsvn/internal-sample-page
davidsmejia
reviewed
Dec 3, 2019
| }; | ||
| } | ||
|
|
||
| export async function getOriginalFiles(sampleId) { |
There was a problem hiding this comment.
Would these functions be better off in ./api/computedFiles.js etc.
davidsmejia
approved these changes
Dec 3, 2019
|
Thanks for reviewing @davidsmejia. Moved the functions into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#702
Purpose/Implementation Notes
This adds an internal samples page that we can use to check sample processing information.
Types of changes
Functional tests
None
Checklist
Screenshots