Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no-op tests #3446

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Fix no-op tests #3446

merged 1 commit into from
Oct 28, 2023

Conversation

arkid15r
Copy link
Contributor

Issue Number

Resolves #3436

Purpose/Implementation Notes

Fix no-op tests

  • Use wget instead of curl for gene index downloads
  • Set specific unzip/rm file instructions
  • Set pre-commit to use Python 3.11

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@arkid15r
Fix no-op tests
273afb3 
  - Use wget instead of curl for gene index downloads
  - Set specific unzip/rm file instructions
  - Set pre-commit to use Python 3.11
@arkid15r arkid15r requested a review from davidsmejia October 27, 2023 23:06
@davidsmejia
Copy link
Contributor

I'll close my PRs this looks good to me!

@arkid15r arkid15r merged commit 14e1835 into dev Oct 28, 2023
19 checks passed
@arkid15r arkid15r deleted the ark/3436-fix-no-op-tests branch October 28, 2023 16:27
@davidsmejia davidsmejia mentioned this pull request Oct 30, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsmejia davidsmejia davidsmejia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test no-op job is failing: Illumina file won't process
2 participants
@arkid15r @davidsmejia