Implement nats avro serdes #5195
Conversation
|
|
||
| T getPayload(); | ||
|
|
||
| void ack(); |
There was a problem hiding this comment.
We should add Nack() and Term() also.
|
|
||
| public static final Integer NATS_PORT = 4222; | ||
|
|
||
| public static final Integer NATS_MGMT_PORT = 8222; |
There was a problem hiding this comment.
8222 is considered to be a monitoring port, can we rename this field to NATS_MNTR_PORT ?
|
|
||
| NatsConsumerRecord<T> receive() throws JetStreamApiException, IOException; | ||
|
|
||
| NatsConsumerRecord<T> receive(Duration timeout) throws JetStreamApiException, IOException; |
There was a problem hiding this comment.
Let's rename it to fetch ?
NATS does not uses receive but pull or fetch.
Difference between pull and fetch is, fetch return the list of messages while pull keeps the message in in memory iterator and users then have to next() to read message from iterator.
|
|
||
| public interface NatsProducer<T> extends AutoCloseable { | ||
|
|
||
| void send(T message) throws ApicurioNatsException; |
There was a problem hiding this comment.
let's rename it to publish and add publishAsync too ?
|
Good comments, I'm going to create an issue so we can track them better. |
|
@sourabhaggrawal I have created the following GH issue to track your comments: #5215. Would you be open to contribute a PR to address them? |
|
Thank you @carlesarnal, I have submitted PR for changes #5222 |
No description provided.