Improvements on Nats Serdes

[souravagrawal]

Fixes #5215

[apicurio-bot]

Thank you for creating a pull request!

Pinging @carlesarnal to respond or triage.

[carlesarnal]

@souravagrawal I'm missing test cases for the newly added methods. You have the exiting one as an example, could you please add tests for the other methods as well?

[sourabhaggrawal]

Implement nats avro serdes #5195

Hi @carlesarnal Yes I have added them now

[sourabhaggrawal]

Hi @carlesarnal I do not understand why test is failing, there is no test with expected value as false in AvroNatsSerdeIT.

[carlesarnal]

@sourabhaggrawal the tests results are apparently not consistent. Can you please take a look?

[sourabhaggrawal]

Hi @carlesarnal apologies for delay in response, test case were working in my setup not sure why its not working here.
I have anyways added a change to check to see if rest of the tests goes through, can you please initiate the workflow once ?

[sourabhaggrawal]

Hi @carlesarnal can you triggered the workflow once again ? It failed again because of indentation and I have pushed a commit with fix.
TIA

[sourabhaggrawal]

HI @carlesarnal can you initiate the workflow again, it has not run after my latest commit.

[sourabhaggrawal]

Thank you @carlesarnal