Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of sentry cli in CI #10977

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix usage of sentry cli in CI #10977

wants to merge 7 commits into from

Conversation

raymondjacobson
Copy link
Member

Description

Upload of sourcemaps broken on CI currently
https://app.circleci.com/pipelines/github/AudiusProject/audius-protocol/68085/workflows/8afcb8c3-463e-4963-ab72-e123239a781c/jobs/1000782

pnpm would be nice here, but this works using npm's script module resolution. Remove redundant install in mobile.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

For web, was able to test via rerunning job with CI

For mobile, was only able to test locally that the script does find the right binary. Will test again on CI

Copy link

changeset-bot bot commented Jan 9, 2025

⚠️ No Changeset found

Latest commit: dfeaa2d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@amendelsohn amendelsohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice ty!

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants