Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of sentry cli in CI #10977

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+201 −155
Open

Fix usage of sentry cli in CI #10977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1233265
Fix usage of sentry cli in CI
raymondjacobson Jan 9, 2025
0232e94
Fix other mobile usage
raymondjacobson Jan 9, 2025
126da28
Fix web install
raymondjacobson Jan 9, 2025
ac8b169
Fix mobile cmds
raymondjacobson Jan 9, 2025
06c2630
Fix mobile
raymondjacobson Jan 9, 2025
db154fd
Improve script
raymondjacobson Jan 9, 2025
dfeaa2d
Fix path
raymondjacobson Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .circleci/src/commands/@mobile-commands.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,6 @@ mobile-prepare-ios:
key: pods-{{ checksum "packages/mobile/ios/Podfile.lock" }}
paths:
- packages/mobile/ios/pods
- run:
name: Install Sentry CLI
command: |
curl -sL https://sentry.io/get-cli/ | bash
echo export SENTRY_BINARY=/usr/local/bin/sentry-cli >> "$BASH_ENV"
- run:
name: Build dependencies
command: npx turbo run build --filter=@audius/mobile
Expand Down
6 changes: 3 additions & 3 deletions .circleci/src/jobs/@web-jobs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,17 +270,17 @@ web-deploy-sentry-sourcemaps:
name: cut-sentry-release
command: |
cd packages/web
../../node_modules/.bin/sentry-cli --auth-token ${SENTRY_AUTH_TOKEN} releases --org audius --project audius-client new ${CIRCLE_SHA1}
npm run sentry-cli -- --auth-token ${SENTRY_AUTH_TOKEN} releases --org audius --project audius-client new ${CIRCLE_SHA1}
- run:
name: upload-sourcemaps
command: |
cd packages/web
../../node_modules/.bin/sentry-cli --auth-token ${SENTRY_AUTH_TOKEN} releases --org audius --project audius-client files ${CIRCLE_SHA1} upload-sourcemaps --no-rewrite build-production/static/js
npm run sentry-cli -- --auth-token ${SENTRY_AUTH_TOKEN} releases --org audius --project audius-client files ${CIRCLE_SHA1} upload-sourcemaps --no-rewrite build-production/static/js
- run:
name: finalize-release
command: |
cd packages/web
../../node_modules/.bin/sentry-cli --auth-token ${SENTRY_AUTH_TOKEN} releases --org audius --project audius-client finalize ${CIRCLE_SHA1}
npm run sentry-cli -- --auth-token ${SENTRY_AUTH_TOKEN} releases --org audius --project audius-client finalize ${CIRCLE_SHA1}

web-dist-mac-staging:
working_directory: ~/audius-protocol
Expand Down
312 changes: 176 additions & 136 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion packages/mobile/ios/.xcode.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,8 @@
# Customize the NODE_BINARY variable here.
# For example, to use nvm with brew, add the following line
# . "$(brew --prefix nvm)/nvm.sh" --no-use
export NODE_BINARY=$(command -v node)
export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" # This loads nvm

export NODE_BINARY=$(command -v node)
export NPM_BINARY=$(command -v npm)
Loading