Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3stream/wal): fix checks before scaleOutWindow #873

Merged
merged 4 commits into from
Jan 3, 2024

fix(wal): shutdown the `pollBlockScheduler` during shutdown

efb9950
Select commit
Loading
Failed to load commit list.
Merged

fix(s3stream/wal): fix checks before scaleOutWindow #873

fix(wal): shutdown the `pollBlockScheduler` during shutdown
efb9950
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 3, 2024 in 1s

54.97% (-0.04%) compared to 1fd1611

View this Pull Request on Codecov

54.97% (-0.04%) compared to 1fd1611

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1fd1611) 55.00% compared to head (efb9950) 54.97%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #873      +/-   ##
============================================
- Coverage     55.00%   54.97%   -0.04%     
+ Complexity     1246     1243       -3     
============================================
  Files           133      133              
  Lines          8535     8535              
  Branches        789      789              
============================================
- Hits           4695     4692       -3     
  Misses         3426     3426              
- Partials        414      417       +3     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.58% <ø> (ø)
RocketMQ Proxy 37.18% <ø> (-0.11%) ⬇️
RocketMQ Store 73.57% <ø> (-0.05%) ⬇️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 2 files with indirect coverage changes