feat: add scriptless bootstrap status poller #5173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into lily/bootstrap-status-poller
…y/bootstrap-status-poller
lilypan26
requested review from
juan-lee,
cameronmeissner and
UtheMan
as code owners
lilypan26
force-pushed
the
lily/bootstrap-status-poller
branch
from
689a0e3
to
0f9cfcc
Compare
added 2 commits
November 1, 2024 11:03
This reverts commit 8f22b14.
added 2 commits
November 4, 2024 09:28
…ootstrap-status-poller
r2k1
reviewed
Nov 4, 2024
lilypan26
force-pushed
the
lily/bootstrap-status-poller
branch
from
8d68c22
to
961c9c1
Compare
r2k1
reviewed
Nov 4, 2024
| @@ -95,6 +102,48 @@ func (a *App) Provision(ctx context.Context, flags ProvisionFlags) error { | |||
| return err | |||
| } | |||
|
|
|||
| func (a *App) ProvisionWait(ctx context.Context) (string, error) { | |||
There was a problem hiding this comment.
Would be nice to have a test watching for a file in tmp folder
There was a problem hiding this comment.
Going to add this in a follow-up PR
r2k1
reviewed
Nov 4, 2024
r2k1
approved these changes
Nov 4, 2024
r2k1
reviewed
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Add monitor mode to go binary to poll status of systemd unit and retrieve bootstrap exit status. Add cse processing to AB e2e to simulate how bootstrapper will retrieve provisioning completion information.
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: