-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add scriptless bootstrap status poller #5173
Merged
Merged
Changes from 53 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
b1f47c3
preserve exit status of csecmd
1ef9491
move nbcparser code to node-bootstrapper
r2k1 ad220a4
move sensitive_string
r2k1 3fda9b6
config version isn't semantic
r2k1 af451af
use node-boostrapper with nbc contract
r2k1 fb30ef7
update tests
r2k1 2b3ea7d
fix node-bootstrapper test
r2k1 d68b75c
add config version validation
r2k1 19edb0d
fix tests
r2k1 a8936f6
update tests
r2k1 47cbaa9
clean things
r2k1 5c894c2
fix tests
r2k1 67798cd
don't build nbcparser
r2k1 3c25712
fix lint error
r2k1 da62a1d
use latest agentbaker version
r2k1 eef6761
merge with master
r2k1 2a499ff
fix tests
r2k1 ec8153b
fix test
r2k1 9a1596d
Merge branch 'r2k1/nbcparser2' of https://github.com/Azure/AgentBaker…
2b8027f
add boostrap status poller
bdf1bfa
add better error handling
f9ad487
improve logging
de266a7
update bootstrap status cse
3218d1e
Merge branch 'master' of https://github.com/Azure/AgentBaker into lil…
4e42e29
add cse script
1be1157
fix systemctl err handling
91c4a5c
add timeout to go monitor mode
4c04ec6
add cse parsing to e2e and provision.json output to go binary
ae67d6b
remove custom_error.go
6055dbe
resolve merge conflicts
ce08ecf
add consts.go
8f57438
add file check
fe869bd
fix scriptless validator
285b8d7
clean up
c57d992
resolve comments, use file wait for polling
3960344
fix file wait and more comments
20928e4
improve error handling for timeout
2f903b3
restore cmdrunner
d7b6183
preserve stdout and stderr of systemctl cmd
11b7055
Merge branch 'master' of https://github.com/Azure/AgentBaker into lil…
c5edade
fix directory watcher
e59f5e8
Merge branch 'dev' of https://github.com/Azure/AgentBaker into lily/b…
36ae4b8
add logging statement
8f22b14
fix file wait using inotify
0f9cfcc
go mod tidy
e50df41
Revert "fix file wait using inotify"
ea27368
wait for provision.complete
7f6060d
change nodebootstrapper bool to string mode
03bfd4e
make generate
5614012
remove timeout from provision-wait
b349ff1
Merge branch 'dev' of https://github.com/Azure/AgentBaker into lily/b…
961c9c1
fix merge conflicts
856cb20
go mod tidy
8cdad95
add wrappers around errors
14ff5ea
Merge branch 'dev' into lily/bootstrap-status-poller
lilypan26 cc332d7
Merge branch 'dev' into lily/bootstrap-status-poller
lilypan26 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
package main | ||
|
||
// Some options are intentionally non-configurable to avoid customization by users | ||
// it will help us to avoid introducing any breaking changes in the future. | ||
const ( | ||
logFile = "/var/log/azure/aks-node-controller.log" | ||
bootstrapService = "bootstrap.service" | ||
provisionJSONFilePath = "/var/log/azure/aks/provision.json" | ||
provisionCompleteFilePath = "/opt/azure/containers/provision.complete" | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have a test watching for a file in tmp folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to add this in a follow-up PR