Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow single parameter dns zone policy #1821

Merged
merged 17 commits into from
Nov 5, 2024

Conversation

jaredfholgate
Copy link
Member

@jaredfholgate jaredfholgate commented Nov 1, 2024

Overview/Summary

A backwards compatible update to the Deploy-Private-DNS-Zones policy set definition.

This enables passing a subscription id, resource group name and region to automatically generate the resource ids for the policy definitions.

This PR fixes/adds/changes/removes

N/A

Breaking Changes

None, designed to be backwards compatible

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

Testing URLs

The below URLs can be updated where the placeholders are, look for {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also} & {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}, to allow you to test your portal deployment experience.

Please also replace the curly brackets on the placeholders {}

Azure Public

Deploy To Azure

Azure US Gov (Fairfax)

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@matt-FFFFFF
Copy link
Member

I get this error when trying to deploy the policy set. Investigating...

Bad Request({"error":{"code":"InvalidPolicyParameters","message":"A function or parameter in policy set or assignment 'Deploy-Private-DNS-Zones' associated with the policy definition '06695360-db88-47f6-b976-7500d4297475' could not be validated. If using template functions, try following the tips in: https://aka.ms/policy-avoiding-template-failures. The inner exception 'The language expression property '' doesn't exist, available properties are 'uaenorth, northcentralus, malaysiawest, eastus, uksouth, westcentralus, israelcentral, southeastasia, malaysiasouth, koreacentral, northeurope, australiaeast, southafricanorth, norwaywest, norwayeast, westus3, eastus2euap, centralus, mexicocentral, canadacentral, japaneast, swedencentral, taiwannorth, germanynorth, centralindia, westindia, newzealandnorth, australiacentral, ukwest, germanywestcentral, brazilsouth, francecentral, brazilsoutheast, westus2, eastus2, centraluseuap, australiacentral2, francesouth, southafricawest, koreasouth, southindia, canadaeast, qatarcentral, spaincentral, westeurope, japanwest, southcentralus, polandcentral, switzerlandwest, australiasoutheast, switzerlandnorth, italynorth, uaecentral, eastasia, chilecentral, westus, swedensouth'.'."}})

@jaredfholgate
Copy link
Member Author

jaredfholgate commented Nov 4, 2024

I get this error when trying to deploy the policy set. Investigating...

Bad Request({"error":{"code":"InvalidPolicyParameters","message":"A function or parameter in policy set or assignment 'Deploy-Private-DNS-Zones' associated with the policy definition '06695360-db88-47f6-b976-7500d4297475' could not be validated. If using template functions, try following the tips in: https://aka.ms/policy-avoiding-template-failures. The inner exception 'The language expression property '' doesn't exist, available properties are 'uaenorth, northcentralus, malaysiawest, eastus, uksouth, westcentralus, israelcentral, southeastasia, malaysiasouth, koreacentral, northeurope, australiaeast, southafricanorth, norwaywest, norwayeast, westus3, eastus2euap, centralus, mexicocentral, canadacentral, japaneast, swedencentral, taiwannorth, germanynorth, centralindia, westindia, newzealandnorth, australiacentral, ukwest, germanywestcentral, brazilsouth, francecentral, brazilsoutheast, westus2, eastus2, centraluseuap, australiacentral2, francesouth, southafricawest, koreasouth, southindia, canadaeast, qatarcentral, spaincentral, westeurope, japanwest, southcentralus, polandcentral, switzerlandwest, australiasoutheast, switzerlandnorth, italynorth, uaecentral, eastasia, chilecentral, westus, swedensouth'.'."}})

Thanks for testing it. I will take a look too and try to fix it. :)

matt-FFFFFF
matt-FFFFFF previously approved these changes Nov 4, 2024
Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Busy testing deployment. Please add a meaningful update to What's New wiki.

@Springstone Springstone added the Test: Hub & Spoke Hub and spoke portal deployment test with full networking label Nov 5, 2024
@jtracey93 jtracey93 merged commit 257a2a1 into main Nov 5, 2024
4 of 5 checks passed
@jtracey93 jtracey93 deleted the feat-allow-single-parameter-dns-zone-policy branch November 5, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Author Feedback Test: Hub & Spoke Hub and spoke portal deployment test with full networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants