-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow single parameter dns zone policy #1821
Conversation
src/resources/Microsoft.Authorization/policySetDefinitions/Deploy-Private-DNS-Zones.json
Outdated
Show resolved
Hide resolved
src/resources/Microsoft.Authorization/policySetDefinitions/Deploy-Private-DNS-Zones.json
Outdated
Show resolved
Hide resolved
src/resources/Microsoft.Authorization/policySetDefinitions/Deploy-Private-DNS-Zones.json
Show resolved
Hide resolved
I get this error when trying to deploy the policy set. Investigating...
|
Thanks for testing it. I will take a look too and try to fix it. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Busy testing deployment. Please add a meaningful update to What's New wiki.
Overview/Summary
A backwards compatible update to the Deploy-Private-DNS-Zones policy set definition.
This enables passing a subscription id, resource group name and region to automatically generate the resource ids for the policy definitions.
This PR fixes/adds/changes/removes
N/A
Breaking Changes
None, designed to be backwards compatible
Testing Evidence
Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
Testing URLs
The below URLs can be updated where the placeholders are, look for
{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}
&{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}
, to allow you to test your portal deployment experience.Azure Public
Azure US Gov (Fairfax)
As part of this Pull Request I have
main
branch/docs/wiki/whats-new.md
)