Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow single parameter dns zone policy #1821

Merged
merged 17 commits into from
Nov 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/wiki/Whats-new.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ Here's what's changed in Enterprise Scale/Azure Landing Zones:
- Bot Service (new) -> AI Bot Services
- Updated the initiative [Deploy-MDFC-Config_20240319](https://www.azadvertizer.net/azpolicyinitiativesadvertizer/Deploy-MDFC-Config_20240319.html) to include an additional parameter that allows you to specify if the Defender for Cloud export to Log Analytics should create a new resource group. This is useful when you want to specify the resource group name or requires tags on resource groups. Will be used by other RIs - Terraform and Bicep (portal accelerator will use default values).
- Updated Automation Account to disable local authentication by default.
- Updated the initiative [Deploy-Private-DNS-Zones](https://www.azadvertizer.net/azpolicyinitiativesadvertizer/Deploy-Private-DNS-Zones.html) to reduce the number of parameters required while retaining backward compatibility. The initiative now only requires the subscription ID, resource group name, and location for the private DNS zone. The DNS zone resource id is now generated based on those inputs. This simplifies usage in the upstream Terraform and Bicep modules.

#### Known Issue

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,9 @@
"azureIotCentralPrivateDnsZoneId": "[concat(variables('baseId'), 'privatelink.azureiotcentral.com')]",
"azureStorageTablePrivateDnsZoneId": "[concat(variables('baseId'), 'privatelink.table.core.windows.net')]",
"azureStorageTableSecondaryPrivateDnsZoneId": "[concat(variables('baseId'), 'privatelink.table.core.windows.net')]",
"azureSiteRecoveryBackupPrivateDnsZoneID": "[concat(variables('baseId'), replace('privatelink.regionGeoShortCode.backup.windowsazure.com','regionGeoShortCode',variables('azBackupGeoCodes')[toLower(parameters('location'))]))]",
"azureSiteRecoveryBlobPrivateDnsZoneID": "[concat(variables('baseId'), 'privatelink.blob.core.windows.net')]",
"azureSiteRecoveryQueuePrivateDnsZoneID": "[concat(variables('baseId'), 'privatelink.queue.core.windows.net')]"
"azureSiteRecoveryBackupPrivateDnsZoneId": "[concat(variables('baseId'), replace('privatelink.regionGeoShortCode.backup.windowsazure.com','regionGeoShortCode',variables('azBackupGeoCodes')[toLower(parameters('location'))]))]",
"azureSiteRecoveryBlobPrivateDnsZoneId": "[concat(variables('baseId'), 'privatelink.blob.core.windows.net')]",
"azureSiteRecoveryQueuePrivateDnsZoneId": "[concat(variables('baseId'), 'privatelink.queue.core.windows.net')]"
},
"policyDefinitions": {
"deployPrivateDnsZones": "[concat('/providers/Microsoft.Management/managementGroups/', parameters('topLevelManagementGroupPrefix'), '/providers/Microsoft.Authorization/policySetDefinitions/Deploy-Private-DNS-Zones')]"
Expand Down Expand Up @@ -404,14 +404,14 @@
"azureStorageTableSecondaryPrivateDnsZoneId": {
"value": "[variables('policyParameterMapping').azureStorageTableSecondaryPrivateDnsZoneId]"
},
"azureSiteRecoveryBackupPrivateDnsZoneID": {
"value": "[variables('policyParameterMapping').azureSiteRecoveryBackupPrivateDnsZoneID]"
"azureSiteRecoveryBackupPrivateDnsZoneId": {
"value": "[variables('policyParameterMapping').azureSiteRecoveryBackupPrivateDnsZoneId]"
},
"azureSiteRecoveryBlobPrivateDnsZoneID": {
"value": "[variables('policyParameterMapping').azureSiteRecoveryBlobPrivateDnsZoneID]"
"azureSiteRecoveryBlobPrivateDnsZoneId": {
"value": "[variables('policyParameterMapping').azureSiteRecoveryBlobPrivateDnsZoneId]"
},
"azureSiteRecoveryQueuePrivateDnsZoneID": {
"value": "[variables('policyParameterMapping').azureSiteRecoveryQueuePrivateDnsZoneID]"
"azureSiteRecoveryQueuePrivateDnsZoneId": {
"value": "[variables('policyParameterMapping').azureSiteRecoveryQueuePrivateDnsZoneId]"
}
}
}
Expand Down
Loading
Loading