Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding pull request template #219

Merged
merged 4 commits into from
Mar 13, 2024
Merged

feat: adding pull request template #219

merged 4 commits into from
Mar 13, 2024

Conversation

abanuelo
Copy link
Contributor

@abanuelo abanuelo commented Mar 7, 2024 •
edited
Loading

The goal of this PR is to introduce a way to format PR's by allowing users to:

  1. Descriptions
  2. Link back to existing issue that trickled the need for the PR
  3. PR Checklist satisfying that formatting, testing, and relevant documentation
  4. Additional info (ie Jira ticket)

@abanuelo abanuelo requested a review from dfremont March 8, 2024 18:41
@Eric-Vin Eric-Vin self-requested a review March 12, 2024 19:04
dfremont
dfremont requested changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one tiny comment above.

@abanuelo abanuelo requested a review from dfremont March 12, 2024 22:28
Eric-Vin
Eric-Vin approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@Eric-Vin Eric-Vin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@abanuelo abanuelo merged commit 39dd102 into main Mar 13, 2024
23 checks passed
@abanuelo abanuelo deleted the abanuelo/pr-template branch April 24, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfremont dfremont dfremont approved these changes

@Eric-Vin Eric-Vin Eric-Vin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abanuelo @dfremont @Eric-Vin