Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: 토너먼트 로직 추가 #99

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Refactor: 토너먼트 로직 추가 #99

merged 2 commits into from
Jun 27, 2024

Conversation

Hosung99
Copy link
Member

#️⃣연관된 이슈

#96

📝작업 내용

토너먼트 관련해서 소켓으로 next_round를 감지하는 함수를 추가했습니다.
추가로 소켓에서 type핸들링 시에 switch문으로 좀 더 깔끔해 보이도록 수정했습니다! (로직은 그대로에요)

스크린샷 (선택)

💬리뷰 요구사항(선택)

코드가 난잡해보이면, 의견남겨주세요!

@Hosung99 Hosung99 added the Refactor Extra attention is needed label Jun 27, 2024
@Hosung99 Hosung99 added this to the 6월 4주차 milestone Jun 27, 2024
@Hosung99 Hosung99 requested a review from mixsung June 27, 2024 05:09
@Hosung99 Hosung99 self-assigned this Jun 27, 2024
Copy link
Contributor

@mixsung mixsung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다

@mixsung mixsung merged commit 57e5897 into dev Jun 27, 2024
@Hosung99 Hosung99 deleted the dev-refactor#96 branch June 27, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants