Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Schnorr/Taproot/Tapscript #758

Open
wants to merge 29 commits into
base: 1.0
Choose a base branch
from
Open

[WIP] Schnorr/Taproot/Tapscript #758

wants to merge 29 commits into from

Conversation

afk11
Copy link
Member

@afk11 afk11 commented Dec 16, 2018

Not for merge yet, but started working on a phpecc-backed implementation of the schnorr signature implementation a while back. Opening the PR so I don't forget about it

@faustbrian
Copy link

What's the status on this?

@afk11
Copy link
Member Author

afk11 commented Jun 21, 2019

Hey. The PR includes an implementation of bip-schnorr https://github.com/sipa/bips/blob/bip-schnorr/bip-schnorr.mediawiki using PHPECC. The implementation is working, but it could do with review by others, especially a cryptographer.

ext-secp256k1 also needs bindings written for schnorr, so we can utilize it here for the second EcAdapter implementation we provide. this stuff can probably come as a separate PR.

The taproot stuff is up for grabs, or I might get it over the next week or two.

@afk11 afk11 force-pushed the schnorr branch 3 times, most recently from 37dd375 to 7704249 Compare October 29, 2019 18:03
@afk11 afk11 changed the title [WIP] Add phpecc backed Schnorr implementation [WIP] Schnorr/Taproot/Tapscript Nov 10, 2019
@afk11 afk11 changed the base branch from master to 1.0 November 11, 2019 12:44
@afk11 afk11 force-pushed the schnorr branch 5 times, most recently from 48a9a76 to c9505db Compare December 10, 2019 23:53
@doxadoxa
Copy link
Contributor

Do you have any updates on this WIP?

@afk11
Copy link
Member Author

afk11 commented Oct 11, 2020

Hi, I left this on standby while libsecp worked things out, as there was quite a bit of code churn on their end. I noticed that PR was merged not too long ago, so might be worth look into this again soon.

@afk11 afk11 mentioned this pull request Jun 16, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants