Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mdanter/ecc to accept v1 and unblock php 8 upgrade #877

Open
wants to merge 1 commit into
base: 1.0
Choose a base branch
from

Conversation

BafS
Copy link

@BafS BafS commented Apr 21, 2021

mdanter/ecc v0.5 requires php ^7.0, the v1 handle php 8 and there is no breaking change

Diff between v0.5.2 and v1.0.0: phpecc/phpecc@v0.5.2...v1.0.0
Release note: https://github.com/phpecc/phpecc/blob/master/doc/release-notes-1.0.0.md

mdanter/ecc v0.5 requires php ^7.0, the v1 handle php 8 and there is no breaking change

Diff between v0.5.2 and v1.0.0
@afk11 afk11 mentioned this pull request Apr 26, 2021
7 tasks
@BafS
Copy link
Author

BafS commented May 5, 2021

@afk11 would it be possible to merge this PR ? It's our last blocker to upgrade to PHP 8

itinance added a commit to itinance/bitcoin-php that referenced this pull request Aug 1, 2021
itinance added a commit to itinance/bitcoin-php that referenced this pull request Aug 1, 2021
@BafS
Copy link
Author

BafS commented Aug 18, 2021

We had to fork; https://github.com/ProtonMail/bitcoin-php and protonlabs/bitcoin on packagist

@envatic
Copy link

envatic commented Apr 13, 2022

We had to fork; https://github.com/ProtonMail/bitcoin-php and protonlabs/bitcoin on packagist

Thanks you saved me the pain, Im working on a package that requires https://github.com/kornrunner/php-keccak and it require mdanter/eec v1 and worse my php version was 8.4. Tnanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants