Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace_axon now allows the axon length and numbr of sections to be set #496

Merged
merged 9 commits into from
Aug 23, 2024

Conversation

Hjorthmedh
Copy link
Contributor

Some of our group members needs the ability to change the length of the axonal initial segment, and the number of sections in it. This pull request adds this ability by introducing axon_stump_length and axon_stump_nsec.

Copy link
Collaborator

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@AurelienJaquier
Copy link
Collaborator

It looks like your changes do pass our pycodestyle tests:

  bluepyopt/ephys/morphologies.py:199:80: E501 line too long (82 > 79 characters)
  bluepyopt/ephys/morphologies.py:211:42: E226 missing whitespace around arithmetic operator
  bluepyopt/ephys/morphologies.py:220:59: E226 missing whitespace around arithmetic operator
  bluepyopt/ephys/morphologies.py:222:80: E501 line too long (85 > 79 characters)

Could you fix that so that the tests pass, please?

@Hjorthmedh
Copy link
Contributor Author

Hjorthmedh commented Aug 16, 2024

@AurelienJaquier Sure, pushed an update.

bluepyopt/ephys/morphologies.py Outdated Show resolved Hide resolved
bluepyopt/ephys/morphologies.py Outdated Show resolved Hide resolved
bluepyopt/ephys/morphologies.py Outdated Show resolved Hide resolved
@Hjorthmedh
Copy link
Contributor Author

Reverted part of the code, to retain default behaviour.

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.38%. Comparing base (43d63a8) to head (e05291c).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
+ Coverage   87.36%   87.38%   +0.01%     
==========================================
  Files          50       50              
  Lines        4346     4351       +5     
==========================================
+ Hits         3797     3802       +5     
  Misses        549      549              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AurelienJaquier AurelienJaquier merged commit 06e42fc into BlueBrain:master Aug 23, 2024
5 checks passed
@AurelienJaquier
Copy link
Collaborator

Thanks @Hjorthmedh for your contribution and your patience

@Hjorthmedh
Copy link
Contributor Author

@AurelienJaquier Thank you! Have a great weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants