New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MPI_COMM_WORLD references #27

Open

jorblancoa opened this issue Apr 14, 2022 · 0 comments

Labels

good first issue

Collaborator

jorblancoa commented Apr 14, 2022

The main communicator should be received as parameter from the simulator.

A good place would be to add an extra parameter in the sonata_setup_communicators(MPI_Comm main_comm) method

libsonatareport/src/library/reports.cpp

Line 69 in 77d5d92

void sonata_setup_communicators() {

CoreNEURON and py-neurodamus core submodule would need to be adapted also:
https://github.com/BlueBrain/CoreNeuron/blob/d0cf5503f1f41fb7d313722e800e306a596bd3b3/coreneuron/io/reports/nrnreport.cpp#L63
https://bbpgitlab.epfl.ch/hpc/sim/neurodamus-core/-/blob/main/mod/SonataReportHelper.mod#L86

jorblancoa added the good first issue label

jorblancoa mentioned this issue

Sync report names across ranks #25

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment