Sync report names across ranks #25
Conversation
jorblancoa
commented
Apr 12, 2022
•
jorblancoa
commented
- Fixed deadlock bug when some ranks don't have all the reports
- Create sub communicators for report names accordingly - Fixed deadlock bug when some ranks dont have all the reports
…report names accordingly - Fixed deadlock bug when some ranks dont have all the reports
|
I have run my CI test with this PR and it solved the deadlock issue. Thanks @jorblancoa |
|
Runing blueconfigs pipeline here |
|
@jorblancoa : let's not forget to update one of the existing BlueConfig to cover this regression :) |
| @@ -129,86 +198,33 @@ struct ParallelImplementation { | |||
| int num_reports = report_names.size(); | |||
| MPI_Comm_split(MPI_COMM_WORLD, num_reports == 0, 0, &SonataReport::has_nodes_); | |||
There was a problem hiding this comment.
I would say it's worth having ticket about not referring to MPI_COMM_WORLD anywhere in the parallel MPI library i.e. when libsonatareport is initialised, the communicator should be passed as an argument (almost always).
There was a problem hiding this comment.
I have created the issue as good for beginners :)
#27
The deadlock issue showed up in the blueconfig ngv test with Fernando's mulitpop improvements, not the main branch. |
