[BBPBGLIB-1153] Allow disabling reports from SONATA config #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test is admittedly not completely end-to-end, but given the other tests there this seemed to me the most logical place to include it. Let me know if I should move it somewhere else. |
jorblancoa
reviewed
Apr 19, 2024
jorblancoa
reviewed
Apr 19, 2024
jorblancoa
requested changes
Apr 19, 2024
jorblancoa
approved these changes
Apr 19, 2024
|
@kbvw , this PR can not trigger our GitLab CI tests because it is requested from the forked repo not the repo branch. |
|
No worries, that's my bad. I just now got added: will open a new one. |
4 tasks
|
Closing in favour of #159. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR solves
https://bbpteam.epfl.ch/project/issues/browse/BBPBGLIB-1153
According to the SONATA specification, reports can be disabled with an optional
enabledparameter in the config file. This option was already parsed, but not used to disable the reports.Scope
A small change to the
enable_reportsmethod of theNodeclass, filtering the reports based on theenabledflag.Testing
An integration test in
tests/integration-e2e/test_reports.py, reusing part of the existing fixture there and reading the flag from a SONATA config file.Review