Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release 3.7.2]: make sure sdist is also published #229

Merged
merged 3 commits into from
Dec 6, 2024
Merged

[Release 3.7.2]: make sure sdist is also published #229

merged 3 commits into from
Dec 6, 2024

Conversation

heerener
Copy link
Collaborator

@heerener heerener commented Dec 6, 2024

Context

3.7.1 was published without a source distribution. This PR adds publishing an sdist

Scope

  • Change in the github actions workflow for publishing sdist

Review

  • PR description is complete
  • Coding style (imports, function length, New functions, classes or files) are good
  • Unit/Scientific test added
  • Updated Readme, in-code, developer documentation

@heerener heerener requested a review from WeinaJi December 6, 2024 10:05
@WeinaJi WeinaJi merged commit c57e016 into main Dec 6, 2024
14 checks passed
@WeinaJi WeinaJi deleted the publish-sdist branch December 6, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeinaJi WeinaJi WeinaJi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heerener @WeinaJi