Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-do metadata fetch until endpoint is fixed #381

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Conversation

ssssarah
Copy link
Contributor

No description provided.

@ssssarah ssssarah requested review from MFSY and crisely09 February 13, 2024 15:49
@codecov-commenter
Copy link

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (7e77eaa) 74.67% compared to head (c01a822) 74.69%.

Files Patch % Lines
kgforge/specializations/stores/bluebrain_nexus.py 4.54% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   74.67%   74.69%   +0.01%     
==========================================
  Files         101      101              
  Lines        6417     6417              
==========================================
+ Hits         4792     4793       +1     
+ Misses       1625     1624       -1     
Flag Coverage Δ
unittests 74.69% <4.54%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

"______________________\n",
"Execution 6 using: id inside: other bucket - Cross bucket: False - Retrieve source: True\n",
"<action> catch_http_error\n",
"<error> RetrievalError: resource 'http://purl.obolibrary.org/obo/GO_0038048' not found in project 'dke/kgforge'\n",
"<error> RetrievalError: 404 Client Error: Not Found for url: https://bbp.epfl.ch/nexus/v1/resources/dke/kgforge/_/http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FGO_0038048\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the error messages using id and self are different, is it possible to make them the same?

Copy link
Contributor

@crisely09 crisely09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests in bmo run fine with these changes. I am not checking too much the code itself as it may change again in the future.

@ssssarah ssssarah merged commit 6ddd5f3 into master Feb 13, 2024
1 check passed
@ssssarah ssssarah deleted the undo_annotate_fetch branch February 15, 2024 15:12
MFSY pushed a commit that referenced this pull request Jul 5, 2024
* re-do metadata fetch until endpoint is fixed

* better notebook

* rename variables

* code style

* fix replace in comments

* update comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants