-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-do metadata fetch until endpoint is fixed #381
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #381 +/- ##
==========================================
+ Coverage 74.67% 74.69% +0.01%
==========================================
Files 101 101
Lines 6417 6417
==========================================
+ Hits 4792 4793 +1
+ Misses 1625 1624 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
"______________________\n", | ||
"Execution 6 using: id inside: other bucket - Cross bucket: False - Retrieve source: True\n", | ||
"<action> catch_http_error\n", | ||
"<error> RetrievalError: resource 'http://purl.obolibrary.org/obo/GO_0038048' not found in project 'dke/kgforge'\n", | ||
"<error> RetrievalError: 404 Client Error: Not Found for url: https://bbp.epfl.ch/nexus/v1/resources/dke/kgforge/_/http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FGO_0038048\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the error messages using id and self are different, is it possible to make them the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests in bmo run fine with these changes. I am not checking too much the code itself as it may change again in the future.
* re-do metadata fetch until endpoint is fixed * better notebook * rename variables * code style * fix replace in comments * update comments
No description provided.