Add pre and post synaptic pathways to BG -> ES projection #4424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinyhappydan
force-pushed
the
search-config-synapses
branch
from
7d63947 to
a7fb6a8
Compare
...iews/src/main/scala/ch/epfl/bluebrain/nexus/delta/plugins/compositeviews/CompositeSink.scala
Outdated
Show resolved
Hide resolved
| @@ -33,8 +33,9 @@ final class GraphResourceToDocument(context: ContextValue, includeContext: Boole | |||
|
|
|||
| /** Given a [[GraphResource]] returns a JSON-LD created from the merged graph and metadata graph */ | |||
| def graphToDocument(element: GraphResource): Task[Option[Json]] = { | |||
| val graph = element.graph ++ element.metadataGraph | |||
| val json = | |||
| implicit val jsonLdOptions = JsonLdOptions.AlwaysEmbed | |||
There was a problem hiding this comment.
Do we need to set this here? Is it not possible to make it an argument to the whole class, so that we can set it to be @always only from the CompositeSink?
There was a problem hiding this comment.
Let me have a think about this one
There was a problem hiding this comment.
I did what you suggested and it works. I think given that this is the smallest possible scope of change, you're right
delta/sdk/src/main/scala/ch/epfl/bluebrain/nexus/delta/sdk/ResourceShift.scala
Outdated
Show resolved
Hide resolved
imsdu
reviewed
Oct 26, 2023
shinyhappydan
force-pushed
the
search-config-synapses
branch
from
a7fb6a8 to
215fb0f
Compare
shinyhappydan
force-pushed
the
search-config-synapses
branch
from
215fb0f to
2cdfc35
Compare
olivergrabinski
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.