Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run SonarSource on demand. #1478

Closed
wants to merge 4 commits into from
Closed

Run SonarSource on demand. #1478

wants to merge 4 commits into from

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Sep 30, 2024

No description provided.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Sep 30, 2024
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Sep 30, 2024
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Sep 30, 2024
@1uc 1uc added run-sonarsource Triggers running SonarSource. benchmark and removed run-sonarsource Triggers running SonarSource. benchmark labels Sep 30, 2024
@github-actions github-actions bot removed the run-sonarsource Triggers running SonarSource. label Sep 30, 2024
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Sep 30, 2024
@1uc 1uc changed the title Speedup sonarsource. Run SonarSource on demand. Oct 1, 2024
@1uc 1uc added the run-sonarsource Triggers running SonarSource. label Oct 1, 2024
@1uc 1uc added run-sonarsource Triggers running SonarSource. and removed run-sonarsource Triggers running SonarSource. labels Oct 1, 2024
@github-actions github-actions bot removed the run-sonarsource Triggers running SonarSource. label Oct 1, 2024
@1uc 1uc added the run-sonarsource Triggers running SonarSource. label Oct 1, 2024
@github-actions github-actions bot removed the run-sonarsource Triggers running SonarSource. label Oct 1, 2024
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Oct 1, 2024
@1uc 1uc marked this pull request as ready for review October 1, 2024 12:05
Copy link
Contributor

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Mentioning this in CONTRIBUTING.rst might be helpful?

@1uc
Copy link
Collaborator Author

1uc commented Oct 2, 2024

BTW, it's now faster than the Windows build; and about as fast as the documentation CI. Might be worth just running it to ensure it doesn't rot away.

@1uc
Copy link
Collaborator Author

1uc commented Oct 3, 2024

Let's leave it in place for now. When it's the last thing to go green, we can turn it off.

@1uc 1uc closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants