Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-bluepyefe: bump to version 2 and remove reference to deprecated branch #1842

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

DrTaDa
Copy link

@DrTaDa DrTaDa commented Feb 21, 2023

No description provided.

@DrTaDa DrTaDa requested a review from genric February 21, 2023 11:05
@github-actions
Copy link

There are one or more issues with the title of this PR.
There are one or more issues with the commit message of commit 758f579.
Commit message:

Bump Bluepyefe to version 2 and remove reference to deprecated branch

Please satisfy at least one of the checks (one package, docs, or deploy).
The PR title must be compliant. The commit message of your commit must be compliant as well.
Issues:

  • The following packages were changed but not mentioned:
    py-bluepyefe:
    You can simply use the above list, then explain what you changed.
    Alternatively, you can use one line per package to describe the change per package.
    Please mention at least one package.

  • The following packages were changed but not mentioned:
    py-bluepyefe:
    You can simply use the above list, then explain what you changed.
    Alternatively, you can use one line per package to describe the change per package.
    Please mention at least one package.

@bbpbuildbot
Copy link
Collaborator

Thank you for your pull request!

Should you want to clear the PR build directory after failures, please use this pipeline. Before running the cleanup pipeline, please ensure that any PR building pipelines have been cancelled or finished running.

@DrTaDa DrTaDa changed the title Bump Bluepyefe to version 2 and remove reference to deprecated branch Bump py-bluepyefe to version 2 and remove reference to deprecated branch Feb 21, 2023
@github-actions
Copy link

There are one or more issues with the title of this PR.
There are one or more issues with the commit message of commit 192eeb2.
Commit message:

Bump py-bluepyefe to version 2 and remove reference to deprecated branch

Please satisfy at least one of the checks (one package, docs, or deploy).
The PR title must be compliant. The commit message of your commit must be compliant as well.
Issues:

  • The following packages were changed but not mentioned:
    py-bluepyefe:
    You can simply use the above list, then explain what you changed.
    Alternatively, you can use one line per package to describe the change per package.
    Please mention at least one package.

  • The following packages were changed but not mentioned:
    py-bluepyefe:
    You can simply use the above list, then explain what you changed.
    Alternatively, you can use one line per package to describe the change per package.
    Please mention at least one package.

@DrTaDa DrTaDa changed the title Bump py-bluepyefe to version 2 and remove reference to deprecated branch py-bluepyefe: bump to version 2 and remove reference to deprecated branch Feb 21, 2023
@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

genric
genric previously approved these changes Feb 21, 2023
@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

@DrTaDa DrTaDa force-pushed the blueyefe_bump branch 2 times, most recently from 81cfd67 to d59b5e6 Compare February 21, 2023 12:51
@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

@DrTaDa
Copy link
Author

DrTaDa commented Feb 21, 2023

@genric I do not understand what is failing, do you know what is up ?

@genric
Copy link

genric commented Feb 21, 2023

nope ;) I guess we'll need @matz-e help...

Copy link
Member

@matz-e matz-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also see this, which probably leads to Spack failing as it does:

spack-old on  blueyefe_bump via 🐍 v3.8.10
❯ rg BPE2
bluebrain/repo-bluebrain/packages/py-bluepyemodel/package.py
28:    depends_on('py-bluepyefe@BPE2', type=('build', 'run'))

This dependency will have to be resolved.

Comment on lines 18 to 20
depends_on('py-numpy', type='run')
depends_on('py-nose', type='run')
depends_on('py-matplotlib', type='run')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
depends_on('py-numpy', type='run')
depends_on('py-nose', type='run')
depends_on('py-matplotlib', type='run')
depends_on('py-numpy', type=('build', 'run'))
depends_on('py-nose', type=('build', 'run'))
depends_on('py-matplotlib', type=('build', 'run'))

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

Please fix the following packages that failed to build:

@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

Please fix the following packages that failed to build:

@DrTaDa
Copy link
Author

DrTaDa commented Feb 21, 2023

Sorry to bother you again @matz-e , how do I see the exact error from the log of the CI ?
I only got to https://bbpgitlab.epfl.ch/hpc/spack/-/snippets/821

@matz-e
Copy link
Member

matz-e commented Feb 22, 2023

Sorry to bother you again @matz-e , how do I see the exact error from the log of the CI ? I only got to https://bbpgitlab.epfl.ch/hpc/spack/-/snippets/821

To the end of one of the lines:

setup.py': [Errno 2] No such file or directory

so... looking at https://github.com/AFM-analysis/igor2 I don't see a setup.py in the repo. This would easily be installed with the next deployment, in the current one I need to see how other packages do it.

(currently Spack does python setup.py install, in the future it will do pip install)

@DrTaDa
Copy link
Author

DrTaDa commented Feb 22, 2023

Indeed, the package owner did a push a few days again to switch to the toml style

@matz-e matz-e mentioned this pull request Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants