deploy: add and update hpctoolkit package for deployment #2000
Conversation
|
Thank you for your pull request! Should you want to clear the PR build directory after failures, please use this pipeline. Before running the cleanup pipeline, please ensure that any PR building pipelines have been cancelled or finished running. |
| @@ -0,0 +1,126 @@ | |||
| from spack.package import * | |||
There was a problem hiding this comment.
(This is referring to the whole file, not that particular line 😅)
There was a problem hiding this comment.
@sergiorg-hpc : so, this new file is copied from upstream's develop branch without any of our custom changes?
There was a problem hiding this comment.
Yup, that is correct, I was just explaining that to @heerener. This contains only the differences between our current upstream version and the actual upstream version of hpctoolkit in the Spack repo.
I remember @matz-e telling me back in the day not to meddle with the original Spack recipes, so that he could update everything at once when he fetches from upstream (this is really back in the day, 1.5 years ago maybe, so perhaps this is no longer valid).
Since then, I have always added patches with new versions. For instance, I did that with arm-forge and other recipes.
If you are fine with the idea of updating the full package specification, @kotsaloscv and I have no objection. We were playing safe here based on what I remembered from @matz-e.
There was a problem hiding this comment.
Ok, understood. I don't know our strategy or recommendation in 2023. Let's wait for a blessing from @matz-e then!
There was a problem hiding this comment.
After clarifying discussion, the idea is: "don't modify anything in builtin that you are not prepared to lose."
Backporting upstream/develop recipes is absolutely fine and even preferred (keeps number of patches lower, and won't interfere / get lost with the next upgrade).
|
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2000/config/modules.sh
module load unstablePlease test the following updated modules:
|
|
Just to update: even the module is built, it’s needed some more work. |
No description provided.