Update processing.py replace_dic ß : b #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge dev into master for version update
merge dev into master for 0.7
add dev optional install for quarto
merge dev into master for version update
update chars to the libr format to fix LectinOracle_flex
merge for version 1.0 update
merge into master for v1.0.1
merge for version update
I've seen the german ß used instead of the greek β, this should help canonicalize this nomenclature dialect.
|
This is an excellent addition, thanks for taking the time! It has also been done correctly but please merge into the dev branch, not the master branch (as the dev branch is the one for active development) Be sure to locally run nbdev_prepare prior to merging but I think it should be okay |
|
The tests all look great but the file conflict issue (https://github.com/BojarLab/glycowork/pull/35/conflicts) is that replace_dic was already modified on the dev branch, so this would roll back the addition on the dev branch, since it was initially based on master. I'd recommend either re-doing it with a fresh pull of dev or doing a second commit to add the addition from dev Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen the german ß used instead of the greek β, this should help canonicalize this nomenclature dialect. This is my first pull request, I'm new to python, and I do not fully grasp how glycowork works so please forgive me if the fix isn't as simple as just adding ß : b in replace_dic in def canonicalize_iupac(glycan) in processing.py.