Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify the computer for a task #78

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

agoscinski
Copy link
Collaborator

@agoscinski agoscinski commented Jan 3, 2025

Requires #77 to be merged before.

The user can specify a computer for a task by the aiida label. A computer be initialized through the verdi CLI or programatically. This is for now the only feasible solution to support the whole scope of connections ssh and firecrest without implementing our own CLI resolution logic.

@leclairm
Copy link
Contributor

leclairm commented Jan 6, 2025

I'm fine with it but not an AiiDA expert so I let @GeigerJ2 and @DropD review it.

@agoscinski agoscinski force-pushed the workgraph-v0.4.10 branch 2 times, most recently from 7b97109 to 998d64a Compare January 9, 2025 15:39
Base automatically changed from workgraph-v0.4.10 to main January 9, 2025 16:47
The user can specify a computer for a task by the aiida label. A computer be
initialized through the verdi CLI or programatically. This is for now the only
feasible solution to support the whole scope of connections ssh and firecrest
without implementing our own CLI resolution logic.
@agoscinski
Copy link
Collaborator Author

@leclairm approved on slack

@agoscinski agoscinski merged commit 4b77727 into main Jan 9, 2025
3 checks passed
@agoscinski agoscinski deleted the computer branch January 9, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants