-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile Smoke Tests #116
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
=======================================
Coverage 95.17% 95.17%
=======================================
Files 26 26
Lines 1284 1284
=======================================
Hits 1222 1222
Misses 62 62 ☔ View full report in Codecov by Sentry. |
01ebf72
to
7d563fd
Compare
7d563fd
to
89e7de0
Compare
sudo apt-get install -y docker-compose | ||
|
||
- name: Start services with docker-compose | ||
run: docker-compose up -d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The compose.yml
file is currently configured for development use, the main differences being it will run jaeger by default and override the default CMD to wrap the web server in an opentelemetry call. Neither of these will likely be used in production environments. Did you consider just using docker on its own to run the API? The only dependency would be a database like postgres.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I could definitly change it to use that. No real reason I did it this way other than it was the first thing I thought of. I'll take a look at just using the dockerfile instead
-H "Content-Type: application/json") | ||
|
||
echo "Response: $RESPONSE_1" | ||
echo "$RESPONSE_1" | grep -q '"is_match":\s*false' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool use of grep. I believe jq
is also available by default on ubuntu-latest if you wanted to use that.
Description
Create a new CI workflow that runs a smoke test job when a PR is open.
Related Issues
closes #103
Additional Notes
The smoke test should roughly do the following, but more steps can be added if identified during the development process
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: