Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDWA-OCR-95] ocr to phdc conversion logic for patient #107

Merged
merged 7 commits into from
Jun 28, 2024

Conversation

arinkulshi-skylight
Copy link
Collaborator

@arinkulshi-skylight arinkulshi-skylight commented May 8, 2024

Pull Request

#95

Description

Integrate the output of OCR into NBS, by generating a PHDC document.

Acceptance Criteria

Map the OCR key/value output into a PHDC input dataclass.
Generate PHDC using the dibbs phdc library, feel free top copy over the code for right now [link]
Integrate patient dataclass only

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.
  • I have notified teammates in the review thread to build awareness.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@arinkulshi-skylight arinkulshi-skylight linked an issue May 8, 2024 that may be closed by this pull request
@arinkulshi-skylight arinkulshi-skylight changed the title added ocr to phdc conversion logic for patient [IDWA-OCR-95] ocr to phdc conversion logic for patient May 14, 2024
from .models import PHDCInputData, Patient, Name, Address, Telecom


class OCRPHDCConverter:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename this to remove the OCR since it doesnt really do OCR stuff

zdeveloper
zdeveloper previously approved these changes Jun 24, 2024
Copy link
Collaborator

@zdeveloper zdeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you

"""
Initializes the PHDC class with a PHDCBuilder.

:param builder: The PHDCBuilder to use to build the PHDC.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: wait do we want to use the data param here?

@arinkulshi-skylight arinkulshi-skylight added this pull request to the merge queue Jun 28, 2024
@knguyenrise8 knguyenrise8 removed this pull request from the merge queue due to a manual request Jun 28, 2024
@arinkulshi-skylight arinkulshi-skylight added this pull request to the merge queue Jun 28, 2024
Merged via the queue into main with commit 60288d7 Jun 28, 2024
2 checks passed
@arinkulshi-skylight arinkulshi-skylight deleted the 95-integrate-the-output-of-ocr-into-nbs branch June 28, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate the output of OCR into NBS
4 participants