Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract skeleton updates #213

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Extract skeleton updates #213

merged 5 commits into from
Sep 9, 2024

Conversation

arinkulshi-skylight
Copy link
Collaborator

@arinkulshi-skylight arinkulshi-skylight commented Sep 5, 2024

Pull Request

Description

#184

add structure to ingest template to local storage(see structure below)
make updates to dropdown.
pass data to the next page through route.

"templates": [
{
"name": "",
"description":"",
"pages": [
{
"image": "base64"
"fieldNames": []
}
]
}
]

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.
  • I have notified teammates in the review thread to build awareness.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@arinkulshi-skylight arinkulshi-skylight marked this pull request as ready for review September 9, 2024 14:53
setTemplates(sampleTemplates);
};

useEffect(() => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spoke to @knguyenrise8 he mentioned the templates do not need to be passed in the route from this page.

zdeveloper
zdeveloper previously approved these changes Sep 9, 2024
Copy link
Contributor

@zdeveloper zdeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with suggestions

OCR/frontend/src/componets/ExtractUploadFile.tsx Outdated Show resolved Hide resolved
OCR/frontend/src/componets/ExtractUploadFile.tsx Outdated Show resolved Hide resolved
}
};

const loadTemplatesFromLocalStorageTestData = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick, rename this to something more accurate, like loadTemplatesTestData since it has nothing to do with LocalStorage

Copy link
Contributor

@zdeveloper zdeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@arinkulshi-skylight arinkulshi-skylight added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit 3445124 Sep 9, 2024
4 checks passed
@arinkulshi-skylight arinkulshi-skylight deleted the extract_skele_updates branch September 9, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants