Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerized Dev Environment #215

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Conversation

schreiaj
Copy link
Collaborator

@schreiaj schreiaj commented Sep 6, 2024

Pull Request

Description

Enables dev environment to be spun up with docker compose -f dev-env.yaml up enables automatic rebuilding on changes and doesn't require environment setup

Related Issues

General Onboarding

Additional Notes

Previous approaches work as normal, this is just to simplify setup on new machines.

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.
  • I have notified teammates in the review thread to build awareness.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

Enables dev environment to be spun up with `docker compose -f
dev-env.yaml up` enables automatic rebuilding on changes and doesn't
require environment setup
@schreiaj schreiaj requested a review from zdeveloper September 6, 2024 20:02
@schreiaj schreiaj marked this pull request as ready for review September 6, 2024 20:02
@schreiaj schreiaj enabled auto-merge September 6, 2024 21:00


# CMD npm run dev -- --host
CMD vite
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does the vite cmd do? is it different from the command in the docker compose yaml

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, great catch - in the compose I overwrite the command so I never really tested it without compose running it. Just updated it to be correct so you can run the just this one instance if you want instead without the compose (not that I'd suggest it)

@schreiaj schreiaj added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit 79e6569 Sep 9, 2024
4 checks passed
@schreiaj schreiaj deleted the schreiaj/dockerized-dev-env branch September 9, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants