Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(365): Add bulk upload #382

Merged
merged 1 commit into from
Nov 8, 2024
Merged

feat(365): Add bulk upload #382

merged 1 commit into from
Nov 8, 2024

Conversation

knguyenrise8
Copy link
Collaborator

Description

  • add bulk upload
  • conditionally render single flow
  • adds bulk api call

Screenshots (if applicable)

Nov-07-2024 15-24-25
Nov-07-2024 15-23-32

Related Issues

[Link any related issues or tasks from your project management system.]

Checklist

  • The title of this PR is descriptive and concise.
  • My changes follow the style guidelines of this project.
  • I have added or updated test cases to cover my changes.
  • I've let the team know about this PR by linking it in the review channel

@knguyenrise8 knguyenrise8 force-pushed the feature/365-bulk-upload branch 4 times, most recently from 76be0ab to b26db29 Compare November 8, 2024 16:58
@knguyenrise8 knguyenrise8 force-pushed the feature/365-bulk-upload branch from b26db29 to 83d5ed3 Compare November 8, 2024 17:04
}
};

const [isUploadComplete, setIsUploadComplete] = useState<boolean>(false);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need a better state solution soon like contextAPI. This is ok for now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

const defaultErrorText = 'This is not a valid file type.'

const filePreviews = []
if (files) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const filePreviews = files?.length
  ? files.map((file) => {
      const imageId = makeSafeForID(file.name)
      const key = `filePreview_${imageId}`
      return (
        <FilePreview
          key={key}
          imageId={imageId}
          file={file}
        />
      )
    })
  : []

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ill make a follow up for this

Copy link
Collaborator

@arinkulshi-skylight arinkulshi-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@knguyenrise8 knguyenrise8 added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit fa89750 Nov 8, 2024
3 checks passed
@knguyenrise8 knguyenrise8 deleted the feature/365-bulk-upload branch November 8, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants