generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Postgres DB and Add DB Variables to Middleware-Api #476
Merged
marycrawford
merged 14 commits into
main
from
revise-postgresdb-and-add-middleware-connection
Dec 12, 2024
Merged
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
bfca53f
updates to db, vault and networking
4e32f98
add output variables for db password, username, db name to middleware…
bf2ee8c
remove commented out code and update middleware-api or app_service mo…
6274f93
minor updates
0bb950f
update app_settings in the middleware
032b93f
removed unused variables
5fdafa9
updates and remove postgres_server_id in the base variables.tf file
3cbacee
remove azurerm_private_endpoint
2085264
remove commented out code
e22c82c
Merge branch 'main' into revise-postgresdb-and-add-middleware-connection
53bd7bc
updates
c9b568f
update vault resource names and attributes
8af1587
update networking to include azurerm_postgresql_flexible_server_firew…
e61b98a
remove commented out code
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
output "postgres_password" { | ||
value = random_string.postgres_password.result | ||
sensitive = true | ||
value = random_string.postgres_password.result | ||
sensitive = true | ||
description = "The randomly generated password for the PostgreSQL database" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,16 @@ | ||
variable "client_id" {} | ||
variable "name" {} | ||
variable "postgres_server_id" {} | ||
marycrawford marked this conversation as resolved.
Show resolved
Hide resolved
|
||
variable "object_id" {} | ||
variable "tenant_id" {} | ||
|
||
variable "sku_name" { | ||
type = string | ||
description = "The Azure Stock Keep Unit (SKU) version" | ||
} | ||
|
||
variable "subscription_id" {} | ||
|
||
variable "resource_group_name" { | ||
description = "value of the Azure resource group to deploy to" | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is giving me an error on my local. not sure why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the
azurerm_private_endpoint
resource, which can be an optional architectural design if we want a higher level security. To unblock the engineers and continue with e2e testing it is best to remove it. However, the communication of the network for the middleware and database respective delegations and app_settings allow it to communicate privately in the vnet.